D7967: KComboBox: Return early when setting editable to previous value

Milian Wolff noreply at phabricator.kde.org
Sun Sep 24 11:55:15 UTC 2017


mwolff created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Instead of creating a new line edit, keep the previous one intact.
  This ensures we don't set a new line edit for code such as the
  following:
  
    KComboBox combo(/* rw = */ true);
    combo.setEditable(true);

REPOSITORY
  R284 KCompletion

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7967

AFFECTED FILES
  autotests/kcombobox_unittest.cpp
  src/kcombobox.cpp

To: mwolff
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170924/26c83f43/attachment.html>


More information about the Kde-frameworks-devel mailing list