D7841: kioexec: Do not start to watch a temporary copy until after the copy is complete

[Jonathan Marten]

marten created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  As described in bug https://bugs.kde.org/show_bug.cgi?id=384500, there appears to be a problem when the receiving application of a file needs a temporary copy to be made (because of %F/%f in its desktop file).  The kded file watching module is told to watch the file too early, before the ioslave has even started to copy it.  This means that when the copy is complete it will receive a dirty signal (on file creation) and the user will immediately be prompted to re-upload.
  
  This change moves the file watch operation to after the file copy job is complete.  At this point the file is in a stable state and hence the dirty signal and the prompt will not happen, unless the file really is subsequently modified.

TEST PLAN
  Built and installed kio with this change, checked remote file opening as per the bug.  Verified that the kded module is not told to watch the file until after the copy is complete, and that there is no re-upload prompt unless the file is actually modified.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7841

AFFECTED FILES
  src/kioexec/main.cpp

To: marten, #frameworks
Cc: elvisangelaccio, dfaure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170915/ad402b31/attachment-0001.html>