D7668: Add Tags browser places item to Dolphin and file pickers by default if Baloo is enabled

[Nathaniel Graham]

ngraham added a comment.


  In https://phabricator.kde.org/D7668#142562, @elvisangelaccio wrote:
  
  > Note that this only works if there are no custom places yet (probably not a big deal).
  
  
  Yes, the idea here is to change the default setting for new installs, and this code is only run the first time, before the user has added any custom places.
  
  Thanks for pointing out the #ifdef HAVE_BALOO issue. I'll admit wasn't actually able to test this due to the Frameworks 5.38.0 bump yesterday which caused a few build issues, and I couldn't get all the dependencies to build. I'll make the requested change, and test when I'm able to sort out the build issues, or when Neon issues package updates for version 5.38.0.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7668

To: ngraham, #frameworks, #dolphin, dfaure, davidedmundson, ltoscano, broulik, elvisangelaccio
Cc: elvisangelaccio, cfeck, navarromorales, nicolasfella, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170903/36399887/attachment.html>