D7668: Add Tags browser places item to Dolphin and file pickers by default if Baloo is enabled

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  Note that this only works if there are no custom places yet (probably not a big deal).

INLINE COMMENTS

> kfileplacesmodel.cpp:110
>                                                QUrl::fromLocalFile(QDir::homePath()), QStringLiteral("user-home"));
> +#ifdef HAVE_BALOO
> +        KFilePlacesItem::createSystemBookmark(d->bookmarkManager,

Doesn't seem to be defined in KIO.

You can use `KProtocolInfo::isKnownProtocol(QStringLiteral("tags"))`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7668

To: ngraham, #frameworks, #dolphin, dfaure, davidedmundson, ltoscano, broulik, elvisangelaccio
Cc: elvisangelaccio, cfeck, navarromorales, nicolasfella, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170903/c08e443a/attachment.html>