D7534: [KUrlNavigator] Emit tabRequested when path in path selector menu is middle-clicked

[David Faure]

dfaure added a comment.


  Maybe it would be safer/simpler to use a different QObject for watching the menus.

INLINE COMMENTS

> kurlnavigator.cpp:365
>      QPointer<QMenu> popup = new QMenu(q);
> +    popup->installEventFilter(q);
>      popup->setLayoutDirection(Qt::LeftToRight);

Warning, that eventFilter method didn't expect to get events for the menu... see below.

> kurlnavigator.cpp:1190
>          }
>          foreach (KUrlNavigatorButton *button, d->m_navButtons) {
>              button->setShowMnemonic(true);

This code will now trigger when the menu loses focus. Won't that have unintended side effects?

> kurlnavigator.cpp:1195
>  
>      case QEvent::FocusOut:
>          foreach (KUrlNavigatorButton *button, d->m_navButtons) {

This code will now trigger when the menu loses focus. Won't that have unintended side effects?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7534

To: broulik, kde-frameworks-devel, dfaure
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170903/c593ecea/attachment.html>