<table><tr><td style="">dfaure added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7534" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Maybe it would be safer/simpler to use a different QObject for watching the menus.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7534#inline-31400" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kurlnavigator.cpp:365</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QPointer</span><span style="color: #aa2211"><</span><span class="n">QMenu</span><span style="color: #aa2211">></span> <span class="n">popup</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QMenu</span><span class="p">(</span><span class="n">q</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">popup</span><span style="color: #aa2211">-></span><span class="n">installEventFilter</span><span class="p">(</span><span class="n">q</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">popup</span><span style="color: #aa2211">-></span><span class="n">setLayoutDirection</span><span class="p">(</span><span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">LeftToRight</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Warning, that eventFilter method didn't expect to get events for the menu... see below.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7534#inline-31402" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kurlnavigator.cpp:1190</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">foreach</span> <span class="p">(</span><span class="n">KUrlNavigatorButton</span> <span style="color: #aa2211">*</span><span class="n">button</span><span class="p">,</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_navButtons</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">button</span><span style="color: #aa2211">-></span><span class="n">setShowMnemonic</span><span class="p">(</span><span style="color: #304a96">true</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This code will now trigger when the menu loses focus. Won't that have unintended side effects?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7534#inline-31401" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kurlnavigator.cpp:1195</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">case</span> <span class="n">QEvent</span><span style="color: #aa2211">::</span><span style="color: #a0a000">FocusOut</span><span class="p">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">foreach</span> <span class="p">(</span><span class="n">KUrlNavigatorButton</span> <span style="color: #aa2211">*</span><span class="n">button</span><span class="p">,</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_navButtons</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This code will now trigger when the menu loses focus. Won't that have unintended side effects?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7534" rel="noreferrer">https://phabricator.kde.org/D7534</a></div></div><br /><div><strong>To: </strong>broulik, kde-frameworks-devel, dfaure<br /><strong>Cc: </strong>Frameworks<br /></div>