D8544: KTextEditor : avoiding QML crashes

[Christoph Cullmann]

cullmann added a comment.


  In Qt 5.6.0 it was already:
  
  static const bool forceMoth = !qEnvironmentVariableIsEmpty("QV4_FORCE_INTERPRETER");
  
  in Qt 5.7.0 it is:
  
  static const bool forceMoth = !qEnvironmentVariableIsEmpty("QV4_FORCE_INTERPRETER") ||
  
    !OSAllocator::canAllocateExecutableMemory();
  
  The warning
  
    if (jitDisabled) {
             qWarning("JIT is disabled for QML. Property bindings and animations will be "
                      "very slow. Visit https://wiki.qt.io/V4 to learn about possible "
                      "solutions for your platform.");
         }
  
  is not guarded with the static, just with !factory, perhaps that can occur multiple times.
  In any case, the setting is fixed after the first call of ExecutionEngine::ExecutionEngine.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D8544

To: rjvbb, #frameworks
Cc: cullmann, kde-frameworks-devel, kevinapavew, demsking, head7, kfunk, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171031/4e72dc1b/attachment.html>