D8243: Implement support for categories on KfilesPlacesView

Renato Oliveira Filho noreply at phabricator.kde.org
Mon Oct 30 15:05:50 UTC 2017


renatoo added inline comments.

INLINE COMMENTS

> ervin wrote in kfileplacesmodel.cpp:476
> Either reorder the enum or change for a different (more explicit not relying on enum storage) comparison operator to have the "right" order. By right order I assume the goal was to align with Dolphin which does: Places / Recently Saved / Search For / Devices.
> 
> Currently we have a different order:  Places / Search For / Recently Saved / Devices.

Are you fine If I set values for enums? Something like:

  enum GroupType
  {
      PlacesType = 100,
      RecentlySavedType = 200,
      SearchForType = 300,
      DevicesType = 400,
      RemovableDeviceType = 500,
      NetworkType = 600
  };

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks, dfaure, ervin, #vdg
Cc: markg, ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171030/3bebc646/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list