D8416: really raising window when shown from systray

[Martin Koller]

mkoller added inline comments.

INLINE COMMENTS

> graesslin wrote in kstatusnotifieritem.cpp:653
> The correct approach would be sni telling the host to activate the window. The host could then communicate with the X11 window manager/Wayland compositor through a special interface that the window should be activated.
> 
> Yes, such an interface does not yet exist. But we need it for Wayland anyway. An app requesting to get activated just does not exist in a Wayland world. The action is performed on the host, so the host is the only one who has enough rights to activate another window.

I'm a bit confused now.
The patch solves my issue for X11 as it does some lines below already, but you say that this is wrong for Wayland but a solution for wayland does not exist right now.
I don't use Wayland, I'm on X11 and on X11 the solution works.
Why can't we simply add this 2 lines until there will be "the correct way" for wayland as you suggest ?
Since you say the current code is wrong anyway, it needs some adaption anyway.
So until then, the current code plus my fix improves the situation for all X11 users, and for Wayland you can change the code when all APIs are in place.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D8416

To: mkoller, davidedmundson, graesslin
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171022/4195ead2/attachment.html>