D8002: Improve DesktopFileParser heuristic for finding old-style service desktop entries

Michael Pyne noreply at phabricator.kde.org
Wed Oct 4 23:21:13 UTC 2017


mpyne added inline comments.

INLINE COMMENTS

> graesslin wrote in desktopfileparser.cpp:547
> Be careful with for and qt containers. This causes a detach. Either use the old variant or wrap the list in qAsConst ( which is new in 5.7)

OK.  I think we settled on Qt 5.6 for now at the request of packagers since it's the latest Qt LTS so I'll use the old variant or manually cast to const.  Thanks for the reminder!

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D8002

To: mpyne, #frameworks
Cc: graesslin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171004/b09d168c/attachment.html>


More information about the Kde-frameworks-devel mailing list