D8002: Improve DesktopFileParser heuristic for finding old-style service desktop entries

Martin Flöser noreply at phabricator.kde.org
Tue Oct 3 18:51:55 UTC 2017


graesslin added inline comments.

INLINE COMMENTS

> desktopfileparser.cpp:547
> +
> +            for(const auto &service : deserializeList(value)) {
>                  // some .desktop files still use the legacy ServiceTypes= key

Be careful with for and qt containers. This causes a detach. Either use the old variant or wrap the list in qAsConst ( which is new in 5.7)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D8002

To: mpyne, #frameworks
Cc: graesslin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171003/fc15a815/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list