D8060: allow to set a custom palette instead of colorSets

David Edmundson noreply at phabricator.kde.org
Mon Oct 2 10:27:16 UTC 2017


davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  1 bug needs fixing.

INLINE COMMENTS

> kiconloader.cpp:142
>  
> -    uintToHex(pal.text().color().rgba(), buffer.data());
> +    uintToHex(pal.windowText().color().rgba(), buffer.data());
>      uintToHex(pal.highlight().color().rgba(), buffer.data() + 8);

pal.window() should be in here too so we cover every palette var used in 
processSvg

> kiconloader.h:464
>      /**
> -     * The color set that will be used for the svg stylesheet in case the
> -     * loaded icons are svg-based, icons can be colored in different ways in
> -     * different areas of the application
> -     * @return one of KColorScheme ColorSet
> -     * @since 5.38
> +     * Sets the colors for this KIconLoader
>       */

@since

REPOSITORY
  R302 KIconThemes

BRANCH
  custompalette

REVISION DETAIL
  https://phabricator.kde.org/D8060

To: mart, dfaure, #frameworks, rikmills, davidedmundson
Cc: davidedmundson, broulik, cfeck, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171002/e06245b9/attachment.html>


More information about the Kde-frameworks-devel mailing list