<table><tr><td style="">davidedmundson accepted this revision.<br />davidedmundson added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8060" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>1 bug needs fixing.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8060#inline-33863" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kiconloader.cpp:142</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">uintToHex</span><span class="p">(</span><span class="n">pal</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">t</span>ext</span><span class="p">().</span><span class="n">color</span><span class="p">().</span><span class="n">rgba</span><span class="p">(),</span> <span class="n">buffer</span><span class="p">.</span><span class="n">data</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">uintToHex</span><span class="p">(</span><span class="n">pal</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">windowT</span>ext</span><span class="p">().</span><span class="n">color</span><span class="p">().</span><span class="n">rgba</span><span class="p">(),</span> <span class="n">buffer</span><span class="p">.</span><span class="n">data</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">uintToHex</span><span class="p">(</span><span class="n">pal</span><span class="p">.</span><span class="n">highlight</span><span class="p">().</span><span class="n">color</span><span class="p">().</span><span class="n">rgba</span><span class="p">(),</span> <span class="n">buffer</span><span class="p">.</span><span class="n">data</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span style="color: #601200">8</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">pal.window() should be in here too so we cover every palette var used in <br />
processSvg</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8060#inline-33864" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kiconloader.h:464</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #74777d">/**</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #74777d">     * <span class="bright">T</span>he color<span class="bright"> set that will be used</span> for th<span class="bright">e svg stylesheet in case the</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #74777d">     * loaded icons are svg-based, icons can be colored in different ways in</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #74777d">     * different areas of the application</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #74777d">     * @return one of KColorScheme ColorSet</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #74777d">     * @since 5.38</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">     * <span class="bright">Sets t</span>he color<span class="bright">s</span> for th<span class="bright">is KIconLoader</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d">     */</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><span class="phabricator-remarkup-mention-unknown">@since</span></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R302 KIconThemes</div></div></div><br /><div><strong>BRANCH</strong><div><div>custompalette</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8060" rel="noreferrer">https://phabricator.kde.org/D8060</a></div></div><br /><div><strong>To: </strong>mart, dfaure, Frameworks, rikmills, davidedmundson<br /><strong>Cc: </strong>davidedmundson, broulik, cfeck, Frameworks<br /></div>