D9070: KDE platform plugin: don't force default stylename on user-specified fonts

[Fabian Vogt]

fvogt added a comment.


  In https://phabricator.kde.org/D9070#173835, @rjvbb wrote:
  
  > >   IMO that's a feature though and is the expected behaviour. For instance, if we change the default window title to be bold, users with "windowTitle=Comic Sans" will also have a bold title.
  >
  > So how would you "change the default window title to be bold"
  
  
  By editing the files in plasma-integration and the fonts kcm  in plasma-desktop, chaning the default stylename and weight.
  
  > and more importantly, how many people are going to have only a font family name in their configuration files? The vast majority will use the available GUI methods for selecting fonts and will end up with a complete specification.
  
  All of those will also have a StyleName, so this here doesn't apply either.
  
  > I'd go one step further: why would changes to defaults override choices already made by users? That's bad practice any way you look at it.
  
  Nothing gets overridden here. It's just that the user didn't specify it.
  
  >>   So just specifying exactly 10 parameters as part of the config key should have the exact same effect.
  > 
  > I don't know what Qfont method that comes from, but experience shows that just removing the stylename extension from the config key (a freshly generated one) doesn't do the trick. IOW, the stylename isn't cleared.
  
  I just checked, the behaviour I described is part of Qt 5.8.0-rc1 and onwards.
  
  In the end, this is just a matter of preference: Should the default stylename for a font family be the same as the stylename we chose as default or just empty?
  The options available in the GUI force a selection of the stylename, so it only applies to migrated and hand-edited configuration anyway.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck
Cc: cfeck, fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171130/784c07d5/attachment-0001.html>