D9049: Compile with:

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> kactioncollectiontest.cpp:235
>      QVERIFY(a->parent() == &collection);
> -    QVERIFY(collection.action(KStandardAction::name(KStandardAction::Undo)) == a);
> +    QVERIFY(collection.action(QString::fromLatin1(KStandardAction::name(KStandardAction::Undo))) == a);
>  }

I'd expect these to be Utf8.

> smtp.cpp:226
>      readBuffer[n] = 0;
> -    lineBuffer += readBuffer;
> -    nl = lineBuffer.indexOf('\n');
> +    lineBuffer += QString::fromLatin1(readBuffer);
> +    nl = lineBuffer.indexOf(QLatin1Char('\n'));

Are you sure it shouldn't be `fromUtf8` or `fromLocal8Bit`?

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D9049

To: mlaurent, dfaure
Cc: apol, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171129/7b5ba584/attachment.html>