<table><tr><td style="">apol added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9049" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9049#inline-40714" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kactioncollectiontest.cpp:235</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QVERIFY</span><span class="p">(</span><span class="n">a</span><span style="color: #aa2211">-></span><span class="n">parent</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span style="color: #aa2211">&</span><span class="n">collection</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">QVERIFY</span><span class="p">(</span><span class="n">collection</span><span class="p">.</span><span class="n">action</span><span class="p">(</span><span class="n">KStandardAction</span><span style="color: #aa2211">::</span><span class="n">name</span><span class="p">(</span><span class="n">KStandardAction</span><span style="color: #aa2211">::</span><span class="n">Undo</span><span class="p">))</span> <span style="color: #aa2211">==</span> <span class="n">a</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QVERIFY</span><span class="p">(</span><span class="n">collection</span><span class="p">.</span><span class="n">action</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">QString</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">fromLatin1</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">KStandardAction</span><span style="color: #aa2211">::</span><span class="n">name</span><span class="p">(</span><span class="n">KStandardAction</span><span style="color: #aa2211">::</span><span class="n">Undo<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>))</span> <span style="color: #aa2211">==</span> <span class="n">a</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I'd expect these to be Utf8.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9049#inline-40713" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">smtp.cpp:226</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">readBuffer</span><span class="p">[</span><span class="n">n</span><span class="p">]</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">lineBuffer</span> <span style="color: #aa2211">+=</span> <span class="n">readBuffer</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">nl</span> <span style="color: #aa2211">=</span> <span class="n">lineBuffer</span><span class="p">.</span><span class="n">indexOf</span><span class="p">(</span><span style="color: #766510">'\n'</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">lineBuffer</span> <span style="color: #aa2211">+=</span> <span class="bright"></span><span class="n"><span class="bright">QString</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">fromLatin1</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">readBuffer<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">nl</span> <span style="color: #aa2211">=</span> <span class="n">lineBuffer</span><span class="p">.</span><span class="n">indexOf</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">QLatin1Char</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #766510">'\n'<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Are you sure it shouldn't be <tt style="background: #ebebeb; font-size: 13px;">fromUtf8</tt> or <tt style="background: #ebebeb; font-size: 13px;">fromLocal8Bit</tt>?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R263 KXmlGui</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9049" rel="noreferrer">https://phabricator.kde.org/D9049</a></div></div><br /><div><strong>To: </strong>mlaurent, dfaure<br /><strong>Cc: </strong>apol, Frameworks<br /></div>