D8862: Extend KFilePlacesModel API

Laurent Montel noreply at phabricator.kde.org
Mon Nov 27 14:40:19 UTC 2017


mlaurent added inline comments.

INLINE COMMENTS

> kfileplacesmodel.cpp:77
> +        if (day > 0) {
> +            date += QString("-%1").arg(day, 2, 10, QChar('0'));
> +        }

QStringLiteral("-%1").arg(...)

> kfileplacesmodel.cpp:96
> +            timelineUrl = QUrl(timelinePrefix + timelineDateString(year, month) +
> +                  '/' + timelineDateString(year, month, day));
> +        } else if (path.endsWith(QLatin1String("/thismonth"))) {

QLatin1Char('/') +

> kfileplacesmodel.cpp:142
> +        } else {
> +            qWarning() << "Invalid search url:" << url;
> +            searchUrl = url;

too bad it doesn't provide debug category here in this lib.
(I will add it today or tomorrow)

but don't care about it

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8862

To: renatoo, dfaure, mwolff
Cc: mlaurent, mwolff, dfaure, ngraham, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171127/5c070526/attachment.html>


More information about the Kde-frameworks-devel mailing list