D8536: Add more hashing algorithms to KPropertiesDialog

Peter Majchrak noreply at phabricator.kde.org
Sun Nov 26 12:11:30 UTC 2017


petermajchrak added a comment.


  I am still not clear on what to do now. Should I revert it to be a lot of separate buttons (hidden in a collapsible group box) (as @elvisangelaccio said) or should I keep it in a dropdown (ok according to me and @anthonyfieroni)?... I'm going to fix some other stuff in the meantime. I also made this `verifyChecksumRecursive` function to verify the checksums serially (one after another)(because up to 2 algorithms can be candidates for certain checksum inputs) to not consume too much resources. I'm thinking of doing that in parallel instead. Do you think it's a good idea? Are there any guidelines for these situations?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8536

To: petermajchrak, elvisangelaccio
Cc: anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171126/70e85794/attachment.html>


More information about the Kde-frameworks-devel mailing list