D8971: Port from QDom to QXmlStreamReader
Kai Uwe Broulik
noreply at phabricator.kde.org
Thu Nov 23 15:59:33 UTC 2017
broulik created this revision.
broulik added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
The Qt Xml module is not actively maintained anymore and docs suggest to use QXmlStreamReader. Also removes the dependency on Qt Xml
TEST PLAN
I can still convert currencies just fine. When the XML file is corrupt, it tries to read it again. It does not try to re-download it, though, but that has been an issue before too (it only checks exists && mtime)
ValueTest fails
FAIL! : ValueTest::testCurrencyNotDownloaded() '!eur.isValid()' returned FALSE. ()
but this is also without this patch and might be an issue when running it locally (it fails even worse if run with locale != en)
REPOSITORY
R292 KUnitConversion
REVISION DETAIL
https://phabricator.kde.org/D8971
AFFECTED FILES
CMakeLists.txt
src/CMakeLists.txt
src/currency.cpp
To: broulik, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171123/c2d2af20/attachment.html>
More information about the Kde-frameworks-devel
mailing list