D8652: Add supported transformations to OutputDevice
Martin Flöser
noreply at phabricator.kde.org
Sat Nov 4 17:39:28 UTC 2017
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in outputdevice_interface.cpp:470
> we have the initial send which is all fine
>
> Then you've got this dynamically add them.
> But at a protocol level we have no way to remove and replace.
> That's somewhat broken.
>
> Personally, I'd just make it a static and document that it must be sent before the first done()
I'm not 100 % sure whether we can in KWin determine the supported rotations in all cases before the OutputDeviceInterface is fully setup. Thus I wanted to have a little bit of flexibility here.
Also if we need it we can add a remove. If we go for a static approach, we cannot remove again.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D8652
To: graesslin, #frameworks, #kwin, #plasma
Cc: davidedmundson, plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171104/1a3bab2b/attachment.html>
More information about the Kde-frameworks-devel
mailing list