D8652: Add supported transformations to OutputDevice

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> outputdevice.xml:225
> +        </description>
> +        <arg name="transformation" type="int" summary="A supported transformation of enum transform on this output"/>
> +    </event>

enum="transform"
also uint

> outputdevice_interface.cpp:470
>  
> +void OutputDeviceInterface::addSupportedTransformation(Transform transformation)
> +{

we have the initial send which is all fine

Then you've got this dynamically add them.
But at a protocol level we have no way to remove and replace.
That's somewhat broken.

Personally, I'd just make it a static and document that it must be sent before the first done()

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D8652

To: graesslin, #frameworks, #kwin, #plasma
Cc: davidedmundson, plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171104/372e290e/attachment.html>