D5856: Use KDirWatch removeDir/addDir instead of stopDirScan/restartDirScan

David Faure noreply at phabricator.kde.org
Sun May 28 08:14:54 UTC 2017


dfaure added a comment.


  I know what the problem is with this.
  Previously, if nobody was watching the directory, stopDirScan/restartDirScan would basically do nothing.
  Now, after running a kio job in that directory, KDirWatch will start watching it, for no purpose, due to the unconditional addDir().
  
  I guess this needs checks with KDirWatch::contains() before removeDir to only call addDir on dirs that were actually watched in the first place...

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5856

To: dfaure, aacid
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170528/18380276/attachment.html>


More information about the Kde-frameworks-devel mailing list