D5856: Use KDirWatch removeDir/addDir instead of stopDirScan/restartDirScan
Albert Astals Cid
noreply at phabricator.kde.org
Sun May 21 22:15:37 UTC 2017
aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.
About the code itself, it looks good, and i've tested dolphin with copy and removes and it seems ok, but on the other hand i understand this is mostly an optimization, so i'm not sure if i would be able to see if it wasn't working fine.
I'm going to say, if we don't have anyone else that can review this, take my +1.
If there's anyone else, i'd be happy to get a second opinion :)
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5856
To: dfaure, aacid
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170521/06b3ce44/attachment.html>
More information about the Kde-frameworks-devel
mailing list