D5639: Internal cache for provider data on initialisation

[Dan Leinir Turthra Jensen]

leinir added inline comments.

INLINE COMMENTS

> dfaure wrote in engine.cpp:58
> The uppercase first letter on variable name is unusual.
> 
> I personally use a s_ prefix for static vars.

Hmm. Right, there is no established way of naming them in KNS already, so while i am not personally so keen on underscores in my variable names, static vars are already sort of ugly, and so going with the "ugly things should look a bit ugly" that stoustrup suggests for c++ things, i kind of like that :)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D5639

To: leinir, whiting, apol
Cc: dfaure, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170507/dcb61859/attachment-0001.html>