D5639: Internal cache for provider data on initialisation

[David Faure]

dfaure added a comment.


  Looks simpler indeed.

INLINE COMMENTS

> engine.cpp:58
> +typedef QHash<QString, XmlLoader*> EngineProviderLoaderHash;
> +Q_GLOBAL_STATIC(QThreadStorage<EngineProviderLoaderHash>, EngineProviderLoaders)
> +

The uppercase first letter on variable name is unusual.

I personally use a s_ prefix for static vars.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D5639

To: leinir, whiting, apol
Cc: dfaure, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170507/1c5dc0c4/attachment-0001.html>