D5090: More focus on KIO than Konqueror

[Luigi Toscano]

ltoscano added inline comments.

INLINE COMMENTS

> lueck wrote in smbrodlg.cpp:176-186
> There are no fields named Browse server, Broadcast address, WINS address in the dialog, see
> https://bugs.kde.org/show_bug.cgi?id=253389
> 
> Last occurences of these strings are in
> https://websvn.kde.org/tags/KDE/3.3.0/kdebase/kcontrol/kio/ksmboptdlg.cpp?view=markup
> 
> ksmboptdialog.cpp was replaced with smbrodlg.cpp without these strings with
> https://websvn.kde.org/trunk/kdebase/kcontrol/kio/smbrodlg.cpp?revision=76131&view=markup&pathrev=76131
> 
> Therefore everything about Browse server, Broadcast address, WINS address  should be removed.
> 
> Otherwise looks good to me.
> 
> Thanks

I will fix it (basically removing most of the text), but I realize now that this KCM should not be here. The kio_smb is in kio-extras, this code should be moved there.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D5090

To: ltoscano, dfaure
Cc: aacid, lueck, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170318/d0a87d42/attachment.html>