D5034: Add support for x-gvfs style options in fstab

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  The patch looks good to me (without testing this locally here). I think the one QStringRef can be turned by to QStringList, since you finally need the QString anyways it seems...

INLINE COMMENTS

> fstabhandling.cpp:152
> +            for (const QStringRef &option : options) {
> +                globalFstabCache->m_fstabOptionsCache.insert(device, option.toString());
> +            }

Well ok, given you need to convert the string to QString finally anyways, you can keep the QStringList above (line 148).

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D5034

To: broulik, #plasma, dfaure, dhaumann
Cc: dhaumann, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170314/fbd3f8cc/attachment-0001.html>