<table><tr><td style="">dhaumann accepted this revision.<br />dhaumann added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5034" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>The patch looks good to me (without testing this locally here). I think the one QStringRef can be turned by to QStringList, since you finally need the QString anyways it seems...</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5034#inline-20655" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fstabhandling.cpp:152</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QStringRef</span> <span style="color: #aa2211">&</span><span style="color: #a0a000">option</span> <span class="p">:</span> <span class="n">options</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span class="n">globalFstabCache</span><span style="color: #aa2211">-></span><span class="n">m_fstabOptionsCache</span><span class="p">.</span><span class="n">insert</span><span class="p">(</span><span class="n">device</span><span class="p">,</span> <span class="n">option</span><span class="p">.</span><span class="n">toString</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Well ok, given you need to convert the string to QString finally anyways, you can keep the QStringList above (line 148).</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R245 Solid</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5034" rel="noreferrer">https://phabricator.kde.org/D5034</a></div></div><br /><div><strong>To: </strong>broulik, Plasma, dfaure, dhaumann<br /><strong>Cc: </strong>dhaumann, plasma-devel, Frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>