D5037: KTextEditor: prevent accidental zooming

[René J.V. Bertin]

rjvbb marked an inline comment as done.
rjvbb added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in kateviewinternal.cpp:76
> About me, it's designed to unset modifiers so param looks unwanted.

I don't disagree but not for exactly the same reason. I'm not sure the function is or should be *designed* for that task. My first reaction to the suggestion of creating a helper class was that it would have this somewhat unexpected side-effect. That's part of why I added a parameter.

Now the real question is of course if there would ever be use for those parameters. I personally see more use for accelerated wheel-scrolling than for wheel-zooming but there are probably other ways to trigger it, rather than a subtle timing trick.

The modifier argument is less doubtful in my mind; it could be under control of a user setting, which would probably even be a prerequisite if someone wants to allow accelerated scrolling (also tied to the Control modifier, AFAIK hardwired in Qt).

REVISION DETAIL
  https://phabricator.kde.org/D5037

To: rjvbb, #ktexteditor
Cc: anthonyfieroni, dhaumann, kwrite-devel, #ktexteditor, #frameworks, head7, cullmann, kfunk, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170314/e733f028/attachment.html>