D5037: KTextEditor: prevent accidental zooming

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kateviewinternal.cpp:76
> +
> +    bool detectZoomingEvent(QWheelEvent *e, bool unsetModifier=true, Qt::KeyboardModifiers modifier=Qt::ControlModifier)
> +    {

About me, it's designed to unset modifiers so param looks unwanted.

> kateviewinternal.cpp:100
> +                    // event and produce normal, not accelerated scrolling
> +                    modState &= ~Qt::ControlModifier;
> +                    e->setModifiers(modState);

modeState &= ~modifier;

REVISION DETAIL
  https://phabricator.kde.org/D5037

To: rjvbb, #ktexteditor
Cc: anthonyfieroni, dhaumann, kwrite-devel, #ktexteditor, #frameworks, head7, cullmann, kfunk, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170314/56fa0772/attachment.html>