D4847: KAuth integration in document saving

[Martin Kostolný]

martinkostolny updated this revision to Diff 12181.
martinkostolny added a comment.


  Thanks for your guidance and for having the patience with me. QScopedPointer was indeed very useful.
  
  One thing I've noticed - it seems there isn't any naming convention for KAuth helper binary. Sometimes it ends with "_helper", sometimes it has different separators like dashes or non separators at all. Shouldn't this binary at least start with proper namespace like "org.kde.ktexteditor" to prevent future collisions?

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4847?vs=12177&id=12181

REVISION DETAIL
  https://phabricator.kde.org/D4847

AFFECTED FILES
  autotests/src/katetextbuffertest.cpp
  autotests/src/katetextbuffertest.h
  src/CMakeLists.txt
  src/buffer/katesecuretextbuffer.cpp
  src/buffer/katesecuretextbuffer.h
  src/buffer/katetextbuffer.cpp
  src/buffer/katetextbuffer.h
  src/buffer/org.kde.ktexteditor.katetextbuffer.actions

To: martinkostolny, dhaumann, #ktexteditor
Cc: anthonyfieroni, cullmann, ltoscano, dhaumann, graesslin, davidedmundson, palant, kwrite-devel, #frameworks, head7, kfunk, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170305/bae5b39c/attachment.html>