D4847: KAuth integration in document saving
Anthony Fieroni
noreply at phabricator.kde.org
Sun Mar 5 06:39:05 UTC 2017
anthonyfieroni added inline comments.
INLINE COMMENTS
> katetextbuffer.cpp:791
> */
> - QSaveFile saveFile(filename);
> - saveFile.setDirectWriteFallback(true);
> + QFileDevice *saveFile = new QSaveFile(filename);
> + static_cast<QSaveFile *>(saveFile)->setDirectWriteFallback(true);
use QScopedPointer, remove manual delete
> katetextbuffer.cpp:886
> #else
> fsync(saveFile.handle());
> #endif
Should be -> instead of .
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4847
To: martinkostolny, dhaumann, #ktexteditor
Cc: anthonyfieroni, cullmann, ltoscano, dhaumann, graesslin, davidedmundson, palant, kwrite-devel, #frameworks, head7, kfunk, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170305/ecf9442f/attachment.html>
More information about the Kde-frameworks-devel
mailing list