Differential e-mail subject re-arrangement

[Dominik Haumann]

Hi,

On Wed, Mar 1, 2017 at 4:16 PM, David Faure <faure at kde.org> wrote:
> On mercredi 1 mars 2017 13:35:47 CET Kevin Funk wrote:
>> On Tuesday, 28 February 2017 21:31:44 CET Michael Pyne wrote:
>> > On Tue, Feb 28, 2017 at 08:38:12PM +0100, Ivan Čukić wrote:
>> > > >   [Differential] D4508: Plasma controls based on QtQuickControls2
>> > > >   [Commented On]> >
>> > > >
>> > > > I personally find that having a "vertical" line in which all the
>> > > > subjects of the differential emails start makes it much easier to
>> > > > read.>
>> > >
>> > > +1 I'd even shorten The 'Differential' part of it to just 'Diff'.
>> >
>> > Agreed to both.
>>
>> +1
>
> Yes, totally, and I would even like the repo name to be added...
>
> But....
>
> https://secure.phabricator.com/D9342 "Make Differential email subject more
> configurable.", ABANDONED.
>
> https://secure.phabricator.com/T5244 "Allow email subjects and bodies to be
> more customizable", CLOSED, WONTFIX.
>
> https://secure.phabricator.com/T10283 "improve differential emails, optimizing
> for efficiency", Open, for a year.
>
> and my own request, https://secure.phabricator.com/T10874, Open, for almost a
> year.
>
> Why did we pick a tool where upstream consistently refuses to make any changes
> that would actually make sense? :(
>
> (see also https://phabricator.kde.org/T5437, "arcanist: option to ignore
> untracked files")

This is unfortunate: I have the *feeling* that the automatically
generated mails contain a lot of noise. I would appreciated to reduce
the contents to a minimum. For instance, imo the commit mails on
kde-commits are just perfect.

With respect to the Differential subjects, I would prefer:
[ktexteditor] D1234: Change this and that... bla bla

Currently, the string "[Differential]" is 100% noise, it provides zero
information, since the D1234 already tells me this is a patch.
Also, I don't need any "[Updated]", or "[Request, 56 lines]" in the subject.

Similarly, since the repository is ideally already in the subject, I
don't want this to be bold and big again stretched over 3 lines in the
email contents. The same holds for the branch, it should be in the
subject, e.g. [ktexteditor/some_branch_name].

Reviewboard was much better here.

KDE is traditionally always very strong technically. We need to keep
this strength also in our infrastructure: Provide exactly the info
that is required, up to the point, and not more. This is essential to
getting work done quickly. The Phab generated mails are step backward
here, imho :-) Would be awesome if this could be improved.

Best regards,
Dominik