[Differential] [Commented On] D4848: Split frag and vert code of FadingNode into separate files

[Kai Uwe Broulik]

broulik added a comment.


  +1

INLINE COMMENTS

> fadingnode.cpp:57
>  {
> -    return "varying highp vec2 v_coord;"
> -    "uniform sampler2D u_src;"
> -    "uniform sampler2D u_target;"
> -    "uniform highp float u_transitionProgress;"
> -    "uniform lowp float qt_Opacity;"
> -    "void main() {"
> -        "lowp vec4 tex1 = texture2D(u_target, v_coord);"
> -        "lowp vec4 tex2 = texture2D(u_src, v_coord);"
> -        "gl_FragColor = mix(tex2, tex1, u_transitionProgress) * qt_Opacity;"
> -    "}";
> +    return QList<QByteArray>() << "qt_Vertex" << "qt_MultiTexCoord0";
>  }

Maybe?

  return {QByteArrayLiteral("..."), QByteArrayLiteral("...")};

> shaders.qrc:2
> +<!DOCTYPE RCC><RCC version="1.0">
> +<qresource prefix="/plasmaframework/shaders">
> +    <file>fadingmaterial.vert</file>

plasma-framework?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4848

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170301/4d1042da/attachment-0001.html>