D6197: Add basic KAuth support to file ioslave
Elias Probst
noreply at phabricator.kde.org
Mon Jun 19 08:59:55 UTC 2017
eliasp added inline comments.
INLINE COMMENTS
> file.h:107
> + };
> + bool execWithRoot(const QString &action, const QString &subAction, const QVariant &args, PriviledgeWarning warning);
> + void endPriviledgeOp();
I find `execWithRoot()` to be a bit misleading, as the goal shouldn't be to always elevate to `root`'s privileges but to only what's required to execute the specific operation (e.g. browse `/home/someotheruser` doesn't need `root`'s privileges but only `someotheruser`'s privileges).
Always elevating to root is IMHO by far too permissive.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6197
To: chinmoyr, elvisangelaccio, #frameworks
Cc: eliasp, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170619/a6646d4b/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list