<table><tr><td style="">eliasp added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6197" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6197#inline-25851" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">file.h:107</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">};</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">bool</span> <span style="color: #004012">execWithRoot</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">action</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">subAction</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QVariant</span> <span style="color: #aa2211">&</span><span class="n">args</span><span class="p">,</span> <span class="n">PriviledgeWarning</span> <span class="n">warning</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">void</span> <span style="color: #004012">endPriviledgeOp</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I find <tt style="background: #ebebeb; font-size: 13px;">execWithRoot()</tt> to be a bit misleading, as the goal shouldn't be to always elevate to <tt style="background: #ebebeb; font-size: 13px;">root</tt>'s privileges but to only what's required to execute the specific operation (e.g. browse <tt style="background: #ebebeb; font-size: 13px;">/home/someotheruser</tt> doesn't need <tt style="background: #ebebeb; font-size: 13px;">root</tt>'s privileges but only <tt style="background: #ebebeb; font-size: 13px;">someotheruser</tt>'s privileges).</p>

<p style="padding: 0; margin: 8px;">Always elevating to root is IMHO by far too permissive.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6197" rel="noreferrer">https://phabricator.kde.org/D6197</a></div></div><br /><div><strong>To: </strong>chinmoyr, elvisangelaccio, Frameworks<br /><strong>Cc: </strong>eliasp, aacid<br /></div>