D5983: Check error status after every PolKitAuthority usage

[Albert Astals Cid]

aacid added a comment.


  In https://phabricator.kde.org/D5983#113988, @skalinichev wrote:
  
  > In https://phabricator.kde.org/D5983#113975, @aacid wrote:
  >
  > > Did you commit this on purpose without the review being accepted or was it a mistake?
  >
  >
  > Yeah, I did it on purpose since:
  >
  > 1. It was on review long enough (more than a week), so anyone who wanted to review it had plenty of time to do so.
  > 2. There are no open issues.
  > 3. The patch itself is very simple: it just checks error status after polkit authority function calls.
  > 4. I've been using it localy on 2 different configurations for more than 2 weeks with no issues.
  >
  >   Anyway if you have any comments regarding this patch please feel free to make a postreiew I'll gladly fix any bugs you can find!
  
  
  I find this impolite, it was on my queue for reviewing properly, just i have had a very busy week.
  
  But anyway you're the maintainer of kauth now, congratulations :)
  
  Please next time you want to commit something because you feel it's been long enough in the queue i would sincerely appreciate if you say "i'll commit this in a week if noone disagrees", it will give people a chance to say "wait i want to have another look"

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D5983

To: skalinichev
Cc: aacid, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170604/ea27cec0/attachment.html>