D6053: Use explicit flag values or explicit constructor instead of nullptr
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Thu Jun 1 11:09:07 UTC 2017
kossebau added inline comments.
INLINE COMMENTS
> cfeck wrote in kfontrequester.cpp:187
> Does removing the default value mean the flags would be now uninitialized?
No, the constructor called would be (as before) `QFlags::QFlags<QFontDialog::FontDialogOption>(Zero zero = Q_NULLPTR)`, so still default to 0 internally, so with no flag set.
(cmp. also https://code.woboq.org/qt5/qtbase/src/corelib/global/qflags.h.html#_ZN6QFlagsC1EMNS_7PrivateEi)
REPOSITORY
R236 KWidgetsAddons
BRANCH
nonullptrforflagsplease
REVISION DETAIL
https://phabricator.kde.org/D6053
To: kossebau, #frameworks, cfeck, kfunk
Cc: kfunk
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170601/56621267/attachment.html>
More information about the Kde-frameworks-devel
mailing list