D6053: Use explicit flag values or explicit constructor instead of nullptr

Kevin Funk noreply at phabricator.kde.org
Thu Jun 1 11:09:00 UTC 2017


kfunk accepted this revision.
kfunk added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> cfeck wrote in kfontrequester.cpp:187
> Does removing the default value mean the flags would be now uninitialized?

No, `QFontDialog::FontDialogOptions` is a `QFlags<>` which has a default constructor which initializes all members.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  nonullptrforflagsplease

REVISION DETAIL
  https://phabricator.kde.org/D6053

To: kossebau, #frameworks, cfeck, kfunk
Cc: kfunk
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170601/409a1f74/attachment.html>


More information about the Kde-frameworks-devel mailing list