D6856: Reset url in closeUrl()

[Elvis Angelaccio]

elvisangelaccio planned changes to this revision.
elvisangelaccio added a comment.


  In https://phabricator.kde.org/D6856#128029, @cullmann wrote:
  
  > Hi, I see the issue that the url is changed without calling setUrl. That doesn't emit urlChanged() that way.
  >  On the other side, if setUrl would be used, you will get the urlChanged twice in openUrl which might lead to not-wanted side-effects.
  
  
  Good catch, this patch is wrong but the fact that the part has an URL set even if it failed to open that URL is a bug that should be fixed, imho.
  I'll try another approach.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D6856

To: elvisangelaccio, dfaure, #ktexteditor, #kate, #kdevelop
Cc: cullmann, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170724/a73f9743/attachment.html>