D6856: Reset url in closeUrl()

[Christoph Cullmann]

cullmann added a comment.


  Hi, I see the issue that the url is changed without calling setUrl. That doesn't emit urlChanged() that way.
  On the other side, if setUrl would be used, you will get the urlChanged twice in openUrl which might lead to not-wanted side-effects.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D6856

To: elvisangelaccio, dfaure, #ktexteditor, #kate, #kdevelop
Cc: cullmann, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170723/254b8d13/attachment.html>