D6767: do not keep constructing new selectionmodels

David Edmundson noreply at phabricator.kde.org
Tue Jul 18 10:40:42 UTC 2017


davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  QAIV creates a new selectionModel whenever we call setModel. (qabstractitemview.cpp:762)
  
  So you're right this is at best, a bit pointlesss, but the fix isn't right, as the code in the new if() will never get called and we won't setSelectionBehavior/setSelectionMode

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D6767

To: sitter, cfeck, davidedmundson
Cc: davidedmundson, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170718/40076dc1/attachment.html>


More information about the Kde-frameworks-devel mailing list