D6672: add KAboutLicense::spdx and introduce orLater qualification
Harald Sitter
noreply at phabricator.kde.org
Mon Jul 17 12:52:43 UTC 2017
sitter marked 3 inline comments as done.
sitter added inline comments.
INLINE COMMENTS
> mpyne wrote in kaboutdata.cpp:166
> Need a setter here for `_versionRestriction`
I am changing this one to delegate to the other ctor actually. Not much point
> mpyne wrote in kaboutdata.cpp:206
> We use `OnlyThisVersion` elsewhere as a default version restriction; using `OrLaterVersions` here causes the auto test you added to break as well. ;)
Ah yes. Good test that ;)
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D6672
To: sitter, sebas, mpyne
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170717/11283650/attachment.html>
More information about the Kde-frameworks-devel
mailing list