D6608: [PlasmaComponents Menu] Don't crash on null action

[Kai Uwe Broulik]

broulik updated this revision to Diff 16452.
broulik edited the summary of this revision.
broulik added a comment.


  - For simplicitly just always delete the current action if it's ours before proceeding. Then either use the one passed in or create a new one. As a (neat) side-effect, explicitly assigning null to an action will also clear the menu item

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6608?vs=16449&id=16452

REVISION DETAIL
  https://phabricator.kde.org/D6608

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qmenuitem.cpp
  tests/components/menu.qml

To: broulik, #plasma
Cc: anthonyfieroni, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170710/2d7f8c1b/attachment.html>