D6608: [PlasmaComponents Menu] Don't crash on null action
Anthony Fieroni
noreply at phabricator.kde.org
Mon Jul 10 13:33:58 UTC 2017
anthonyfieroni added inline comments.
INLINE COMMENTS
> qmenuitem.cpp:47
> + m_hasExplicitAction = true;
> + delete m_action;
> + m_action = nullptr;
Why delete it?
if (!a) {
setVisible(false);
return;
}
// m_action stays last one, but disconnected. And we want to have last one "inactive"?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6608
To: broulik, #plasma
Cc: anthonyfieroni, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170710/3e05d78a/attachment.html>
More information about the Kde-frameworks-devel
mailing list