D5208: Allow loading i18n catalogs from arbitrary locations

Chusslove Illich noreply at phabricator.kde.org
Tue Jul 4 07:49:37 UTC 2017


ilic accepted this revision.
ilic added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> davidedmundson wrote in kcatalog.cpp:124
> I think I still need it.
> 
> QHash::value() isn't marked as being atomic so we still need to make sure we're not reading at the same time as someone else is modifying the hash table.

Hm, right... That makes me wonder where else there should be a lock and it's missing :) But that's for another story.

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5208

To: davidedmundson, #frameworks, ilic
Cc: ilic
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170704/a6f4a264/attachment.html>


More information about the Kde-frameworks-devel mailing list