D5208: Allow loading i18n catalogs from arbitrary locations

David Edmundson noreply at phabricator.kde.org
Tue Jul 4 06:48:07 UTC 2017


davidedmundson marked an inline comment as done.
davidedmundson added inline comments.

INLINE COMMENTS

> ilic wrote in kcatalog.cpp:124
> Also the lock should be removed, now that only read access is used.

I think I still need it.

QHash::value() isn't marked as being atomic so we still need to make sure we're not reading at the same time as someone else is modifying the hash table.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D5208

To: davidedmundson, #frameworks, ilic
Cc: ilic
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170704/f06474e5/attachment.html>


More information about the Kde-frameworks-devel mailing list