Review Request 129885: [KStandadAction] Correct menubars logic

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129885/#review102318
-----------------------------------------------------------



This patch makes no sense (somehow you wait for two shows to happen) and you even have tried it where it makes sense so -1

- Albert Astals Cid


On Jan. 25, 2017, 8:39 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129885/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2017, 8:39 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid and David Faure.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> -------
> 
> This patch (https://git.reviewboard.kde.org/r/129261/) is *ugly* makes side effects on KDE menubars. Start Dolphin -> hide menubar -> restart it -> click control button -> menubar action is checked.
> It hide all actions changed between updateAction calls e.g.
> updateAction (stores last state of checked and enable)
> application changed menu action like it want
> updateAction is called on show event -> discard modified states
> 
> 
> Diffs
> -----
> 
>   src/kstandardaction.cpp 6e5bba7 
> 
> Diff: https://git.reviewboard.kde.org/r/129885/diff/
> 
> 
> Testing
> -------
> 
> Works correct on KDE, test it on Unity.
> Please don't make such a patch, respect application behavior.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170129/366b271c/attachment.html>