Review Request 129885: [KStandadAction] Correct menubars logic

[Albert Astals Cid]

> On Jan. 25, 2017, 11:15 p.m., Albert Astals Cid wrote:
> > I briefly looked at dolphins code a while ago and i'm pretty sure the code is wrong in dolphin
> 
> Albert Astals Cid wrote:
>     BTW what do you mean with "Works correct on KDE"?
> 
> Anthony Fieroni wrote:
>     The code in Dolphin isn't wrong, the application should be able to change action state whenever he wants. So when spy show event there is no right way to change action state in application. Your patch approach is to detemine native menubars, in KDE i get allMenuBarsNative = false, wasNative = true, in Unity i suppose to be true -> true.

This has nothing to do with whether you are using Unity or Plasma (which for some reason you keep wrongly calling KDE).

See https://git.reviewboard.kde.org/r/129892/


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129885/#review102239
-----------------------------------------------------------


On Jan. 25, 2017, 8:39 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129885/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2017, 8:39 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid and David Faure.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> -------
> 
> This patch (https://git.reviewboard.kde.org/r/129261/) is *ugly* makes side effects on KDE menubars. Start Dolphin -> hide menubar -> restart it -> click control button -> menubar action is checked.
> It hide all actions changed between updateAction calls e.g.
> updateAction (stores last state of checked and enable)
> application changed menu action like it want
> updateAction is called on show event -> discard modified states
> 
> 
> Diffs
> -----
> 
>   src/kstandardaction.cpp 6e5bba7 
> 
> Diff: https://git.reviewboard.kde.org/r/129885/diff/
> 
> 
> Testing
> -------
> 
> Works correct on KDE, test it on Unity.
> Please don't make such a patch, respect application behavior.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170126/16b58bdd/attachment.html>