[Differential] [Updated] D4227: Don't block when running the post-install command

Aleix Pol Gonzalez noreply at phabricator.kde.org
Mon Jan 23 12:16:37 UTC 2017


apol marked an inline comment as done.
apol added inline comments.

INLINE COMMENTS

> mart wrote in installation.h:137
> BIC
> even if the api of this file is beyond terrible, unfortunately it's exported, so no binary incompatible changes should occur

According to our BIC documentation: https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B

We can "remove private non-virtual functions if they are not called by any inline functions (and have never been)."

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D4227

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, leinir, whiting, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170123/daf2d89c/attachment.html>


More information about the Kde-frameworks-devel mailing list